Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): always have qwik binary available #7004

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(build): always have qwik binary available #7004

merged 1 commit into from
Oct 28, 2024

Conversation

wmertens
Copy link
Member

To have the bin qwik working during installs, the file it points to from package.json must exist.

We already had a perpetual script in the qwik package but it got ignored at some point.

To have the bin `qwik` working during installs, the file it points to from package.json must exist.

We already had a perpetual script in the qwik package but it got ignored at some point.
@wmertens wmertens requested a review from a team as a code owner October 27, 2024 09:24
Copy link

changeset-bot bot commented Oct 27, 2024

⚠️ No Changeset found

Latest commit: 2b3693f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 27, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7004
npm i https://pkg.pr.new/@builder.io/qwik-city@7004
npm i https://pkg.pr.new/eslint-plugin-qwik@7004
npm i https://pkg.pr.new/create-qwik@7004

commit: 2b3693f

Copy link
Contributor

github-actions bot commented Oct 27, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 2b3693f

Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wout!

@wmertens wmertens merged commit eb4ca93 into main Oct 28, 2024
21 checks passed
@wmertens wmertens deleted the fix-qwik-bin branch October 28, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants